linux-kernel - Re: [PATCH] PM / devfreq: fix missing unlock on error in exynos4_busfreq_pm_notifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <11191890.8oYqJ4b1Vm@vostro.rjw.lan>
Date:	Fri, 22 Feb 2013 13:41:51 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	myungjoo.ham@...sung.com
Cc:	Nishanth Menon <nm@...com>, Wei Yongjun <weiyj.lk@...il.com>,
	박경민 <kyungmin.park@...sung.com>,
	"yongjun_wei@...ndmicro.com.cn" <yongjun_wei@...ndmicro.com.cn>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] PM / devfreq: fix missing unlock on error in exynos4_busfreq_pm_notifier_event()

On Friday, February 22, 2013 06:33:58 AM MyungJoo Ham wrote:
> > On 12:33-20130222, Wei Yongjun wrote:
> > > From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> > > 
> > > Add the missing unlock before return from function
> > > exynos4_busfreq_pm_notifier_event() in the error
> > > handling case.
> > > 
> > > This issue introduced by commit 8fa938
> > > (PM / devfreq: exynos4_bus: honor RCU lock usage)
> > > 
> > > Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> > Arrgh.. Thanks for catching this :( My bad.
> > 
> > Fix looks good to me. upto  MyungJoo.
> 
> Applied to devfreq repository.
> I'll send pull request to Rafael soon along with other patches.
> 
> > 
> > MyungJoo, Rafael,
> > btw, adding linux-pm@...r.kernel.org to  MAINTAINERS for devfreq might
> > be a nice idea to have right audience.
> 
> It appears that replacing the current mailing list address with linux-pm is
> appropriate. If no one objects, I'll post the suggestion later.

Sure, please do.

Thanks,
Rafael


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/