| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <10415300.xy5iOWqAMD@vostro.rjw.lan> Date: Fri, 22 Feb 2013 03:33:56 +0100 From: "Rafael J. Wysocki" <rjw@...k.pl> To: Viresh Kumar <viresh.kumar@...aro.org> Cc: cpufreq@...r.kernel.org, linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org, robin.randhawa@....com, Steve.Bannister@....com, Liviu.Dudau@....com, charles.garcia-tobin@....com, linaro-dev@...ts.linaro.org, francescolavra.fl@...il.com, toddpoynor@...gle.com Subject: Re: [PATCH V2 4/4] cpufreq: Get rid of "struct global_attr" On Friday, February 22, 2013 07:47:44 AM Viresh Kumar wrote: > On 22 February 2013 05:15, Rafael J. Wysocki <rjw@...k.pl> wrote: > > Why did you change all of the lines of this macro instead of changing just the > > one line you needed to change? > > I didn't like the indentation used within the macro. So did it. In general, things like that are for separate cleanup patches. If you mix functional changes with cleanups, poeple get confused and it's difficult to see what's needed and what's "optional". I know it's tempting to fix stuff like that along with doing functional changes and I do that sometimes. Not very often, though, and with care. Thanks, Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists