linux-kernel - Re: [PATCH] PM / devfreq: fix missing unlock on error in exynos4_busfreq_pm_notifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130222044917.GA24752@kahuna>
Date:	Thu, 21 Feb 2013 22:49:17 -0600
From:	Nishanth Menon <nm@...com>
To:	Wei Yongjun <weiyj.lk@...il.com>
CC:	<myungjoo.ham@...sung.com>, <kyungmin.park@...sung.com>,
	<yongjun_wei@...ndmicro.com.cn>, <linux-kernel@...r.kernel.org>,
	<rjw@...k.pl>
Subject: Re: [PATCH] PM / devfreq: fix missing unlock on error in
 exynos4_busfreq_pm_notifier_event()

On 12:33-20130222, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> 
> Add the missing unlock before return from function
> exynos4_busfreq_pm_notifier_event() in the error
> handling case.
> 
> This issue introduced by commit 8fa938
> (PM / devfreq: exynos4_bus: honor RCU lock usage)
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> ---
>  drivers/devfreq/exynos4_bus.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/devfreq/exynos4_bus.c b/drivers/devfreq/exynos4_bus.c
> index 46d94e9..6208a68 100644
> --- a/drivers/devfreq/exynos4_bus.c
> +++ b/drivers/devfreq/exynos4_bus.c
> @@ -974,6 +974,7 @@ static int exynos4_busfreq_pm_notifier_event(struct notifier_block *this,
>  			rcu_read_unlock();
>  			dev_err(data->dev, "%s: unable to find a min freq\n",
>  				__func__);
> +			mutex_unlock(&data->lock);
>  			return PTR_ERR(opp);
>  		}
>  		new_oppinfo.rate = opp_get_freq(opp);
> 
> 
Arrgh.. Thanks for catching this :( My bad.

Fix looks good to me. upto  MyungJoo.

MyungJoo, Rafael,
btw, adding linux-pm@...r.kernel.org to  MAINTAINERS for devfreq might
be a nice idea to have right audience.
-- 
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/