linux-kernel - Re: [PATCH] arch/x86/xen: remove depends on CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130223191104.GA12606@konrad-lan.dumpdata.com>
Date:	Sat, 23 Feb 2013 14:11:05 -0500
From:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To:	Kees Cook <keescook@...omium.org>
Cc:	Dongsheng Song <dongsheng.song@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Jeremy Fitzhardinge <jeremy@...p.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	"x86@...nel.org" <x86@...nel.org>, xen-devel@...ts.xensource.com,
	virtualization@...ts.linux-foundation.org,
	Stefano Stabellini <stefano.stabellini@...citrix.com>,
	Mukesh Rathor <mukesh.rathor@...cle.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] arch/x86/xen: remove depends on CONFIG_EXPERIMENTAL

On Sat, Feb 23, 2013 at 09:03:20AM -0800, Kees Cook wrote:
> On Sat, Feb 23, 2013 at 3:59 AM, Dongsheng Song
> <dongsheng.song@...il.com> wrote:
> > On Sat, Feb 23, 2013 at 3:29 PM, Kees Cook <keescook@...omium.org> wrote:
> >>
> >> The CONFIG_EXPERIMENTAL config item has not carried much meaning for a
> >> while now and is almost always enabled by default. As agreed during the
> >> Linux kernel summit, remove it from any "depends on" lines in Kconfigs.
> >>
> >> Signed-off-by: Kees Cook <keescook@...omium.org>
> >> Cc: Stefano Stabellini <stefano.stabellini@...citrix.com>
> >> Cc: Mukesh Rathor <mukesh.rathor@...cle.com>
> >> Cc: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
> >> ---
> >>  arch/x86/xen/Kconfig |    2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig
> >> index 93ff4e1..8cada4c 100644
> >> --- a/arch/x86/xen/Kconfig
> >> +++ b/arch/x86/xen/Kconfig
> >> @@ -53,7 +53,7 @@ config XEN_DEBUG_FS
> >>
> >>  config XEN_X86_PVH
> >>         bool "Support for running as a PVH guest (EXPERIMENTAL)"
> >
> > Why not remove this 'EXPERIMENTAL' too ?
> 
> It was unclear to me if the feature was actually considered unstable.
> I can resend with the text removed from the title too, if that's the
> correct action here?

It certainly is unstable right now (which is why it was unstaged from
the v3.9 train). I hope that by v3.10 it won't be - at which
point this patch (and the EXPERIMENTAL) makes sense.

So could you respin it please with the text removed as well - and I will
queue it up in the branch that carries the PVH feature?

Thanks!
> 
> -Kees
> 
> >
> >> -       depends on X86_64 && XEN && EXPERIMENTAL
> >> +       depends on X86_64 && XEN
> >>         default n
> >>         help
> >>            This option enables support for running as a PVH guest (PV guest
> >> --
> >> 1.7.9.5
> >>
> >>
> >> --
> >> Kees Cook
> >> Chrome OS Security
> >> --
> >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> >> the body of a message to majordomo@...r.kernel.org
> >> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >> Please read the FAQ at  http://www.tux.org/lkml/
> 
> 
> 
> -- 
> Kees Cook
> Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/