linux-kernel - Re: [GIT PULL] x86/mm changes for v3.9-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE9FiQVPwD14j2FGyW9NZqXqo1MyaP0M9mGcirAWo=hM8fP_Lg@mail.gmail.com>
Date:	Sat, 23 Feb 2013 13:37:38 -0800
From:	Yinghai Lu <yinghai@...nel.org>
To:	Konrad Rzeszutek Wilk <konrad@...nel.org>
Cc:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	"H. Peter Anvin" <hpa@...ux.intel.com>,
	Stefano Stabellini <stefano.stabellini@...citrix.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] x86/mm changes for v3.9-rc1

On Sat, Feb 23, 2013 at 11:43 AM, Konrad Rzeszutek Wilk
<konrad@...nel.org> wrote:
>> >> Also you should check condition about calling xen_get_user_pgd().
>> >
>> > Could you elaborate please?
>>
>> only call xen_get_user_pgd() when it should be called.
>
> I should have been more explicit. When I was saying "elaborate" I was
> soliciting for advice on the 'check condition' and how to make it robust.

your 64bit xen_write_cr3_init, is just xen_write_cr3 without
xen_get_user_pgd calling.
plus set xen_write_cr3 to ops.write_cr3.

so if you could have way to find out when xen_get_user_pgd could be used,
new xen_write_cr3_init need to check that, then set ops.write_cr3 and
call ops.write_cr3
otherwise will still call slim version without update ops.write_cr3
and bail out early.

Thanks

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/