linux-kernel - Re: [PATCH] clocksource : nomadik-mtu : fix missing irq initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51285F51.5040902@linaro.org>
Date:	Sat, 23 Feb 2013 07:18:57 +0100
From:	Daniel Lezcano <daniel.lezcano@...aro.org>
To:	Linus Walleij <linus.walleij@...aro.org>
CC:	john.stultz@...aro.org, tglx@...utronix.de,
	linus.walleij@...ricsson.com, linaro-kernel@...ts.linaro.org,
	linux-kernel@...r.kernel.org, patches@...aro.org
Subject: Re: [PATCH] clocksource : nomadik-mtu : fix missing irq initialization

On 02/22/2013 06:21 PM, Linus Walleij wrote:
> On Fri, Feb 22, 2013 at 4:44 PM, Daniel Lezcano
> <daniel.lezcano@...aro.org> wrote:
> 
>> This patch fix the clock device irq field which is not initialized.
>>
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>
> 
> Makes perfect sense:
> Acked-by: Linus Walleij <linus.walleij@...aro.org>
> 
> Sorry that I might have missed some background here or just be
> out-of-track with things, how did this driver work for years without
> the irq assigned? Or was this field recently introduced?

The irq is assigned through:

setup_irq(irq, &nmdk_timer_irq);

two lines above but the clockevent's irq field was not set.

I did not investigate a lot, but at the first glance it worked because
the code path used by the default kernel configuration (CONFIG_NO_HZ)
does not use this field.

But when using the dynamic irq affinity [1], I noticed it was set to 0.

[1] http://www.spinics.net/lists/arm-kernel/msg226371.html

Thanks
  -- Daniel


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/