linux-kernel - Re: [PATCH 4/5] perf, x86: Support full width counting v3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130224120726.GB20905@gmail.com>
Date:	Sun, 24 Feb 2013 13:07:26 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	linux-kernel@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Arnaldo Carvalho de Melo <acme@...radead.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 4/5] perf, x86: Support full width counting v3


* Andi Kleen <andi@...stfloor.org> wrote:

> Recent Intel CPUs like Haswell and IvyBridge have a new 
> alternative MSR range for perfctrs that allows writing the 
> full counter width. Enable this range if the hardware reports 
> it using a new capability bit.
> 
> This lowers the overhead of perf stat slightly because it has
> to do less interrupts to accumulate the counter value. On
> Haswell it also avoids some problems with TSX aborting when
> the end of the counter range is reached.
>
> This can be observed when the checkpoint flag has been set, 
> which has been enabled by the basic PMU patch. An overflow 
> will abort the transaction and set the counter back. If the 
> counter is near the overflow before the transaction this could 
> happen continuously, forcing a transaction to continuously 
> abort.
>
> This is a partial fix, but it makes the overflows much less 
> likely by using a larger counter, to lower the probability of 
> the event. Additional counter measures are in the additional 
> extended Haswell patchkit.

It would actually be _much_ more useful to first try to fix that 
condition - then extend the counter range. As you say it in the 
changelog it can happen anyway: and it's much more testable if 
the counter width is narrower initially.

Mind restructuring the basic patches thusly, putting the fix 
first and moving the counter extension to the later patches?

(If you don't have the time for that we can delay it all to 
v3.10, it's pretty late already even for v3.9.)

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/