linux-kernel - Re: [PATCH] backlight: ams369fg06: convert ams369fg06 to dev_pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <01e501ce12fa$9b90b8c0$d2b22a40$%han@samsung.com>
Date:	Mon, 25 Feb 2013 10:51:19 +0900
From:	Jingoo Han <jg1.han@...sung.com>
To:	'Andrew Morton' <akpm@...ux-foundation.org>
Cc:	'LKML' <linux-kernel@...r.kernel.org>,
	'Richard Purdie' <rpurdie@...ys.net>,
	'Jingoo Han' <jg1.han@...sung.com>
Subject: Re: [PATCH] backlight: ams369fg06: convert ams369fg06 to dev_pm_ops

On Saturday, February 23, 2013 6:26 AM, Andrew Morton wrote:
> 
> On Fri, 22 Feb 2013 19:42:59 +0900
> Jingoo Han <jg1.han@...sung.com> wrote:
> 
> > Instead of using legacy suspend/resume methods, using newer dev_pm_ops
> > structure allows better control over power management.
> >
> > ...
> >
> > @@ -571,12 +571,13 @@ static struct spi_driver ams369fg06_driver = {
> >  	.driver = {
> >  		.name	= "ams369fg06",
> >  		.owner	= THIS_MODULE,
> > +#ifdef CONFIG_PM
> > +		.pm	= &ams369fg06_pm_ops,
> > +#endif
> >  	},
> >  	.probe		= ams369fg06_probe,
> >  	.remove		= ams369fg06_remove,
> >  	.shutdown	= ams369fg06_shutdown,
> 
> Are the ifdefs needed?  There's various macro trickery in pm.h to clean
> this up - the rtc drivers use it.

OK, you're right.
I will remove unnecessary '#ifdef CONFIG_PM'.
Thank you for your comment.

Best regards,
Jingoo Han



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/