linux-kernel - Re: [PATCH 01/35] mfd: ab8500-gpadc: Implemented suspend/resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130225135123.GA28907@opensource.wolfsonmicro.com>
Date:	Mon, 25 Feb 2013 13:51:24 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Ulf Hansson <ulf.hansson@...aro.org>
Cc:	Lee Jones <lee.jones@...aro.org>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	sameo@...ux.intel.com, arnd@...db.de, linus.walleij@...ricsson.com,
	Daniel WILLERUD <daniel.willerud@...ricsson.com>
Subject: Re: [PATCH 01/35] mfd: ab8500-gpadc: Implemented suspend/resume

On Mon, Feb 25, 2013 at 10:27:36AM +0100, Ulf Hansson wrote:
> On 22 February 2013 11:38, Mark Brown

> > Are you sure this actually does what you think it does, especially when
> > run on modern kernels?

> Not sure, what you are thinking of more precisely here. Runtime pm has
> been in the kernel for quite some time now.

Yes, thanks - I was aware of that.  The integration between runtime and
system PM has been an area that's had some development though.

> Anyway, to make it a bit clearer, we switch the regulator on/off at
> the runtime suspend/resume callbacks. We want to take similar actions
> in device suspend/resume.
> To accomplish this a pm_runtime_get_sync is done in suspend and vice
> verse in resume, otherwise you can not safely handle the regulator.

Are you absolutely positive that with modern kernels your get actually
resumes the device?

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)