linux-kernel - Re: [PATCH 0/5] [v3] fix illegal use of _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <512B784E.5070002@linux.vnet.ibm.com>
Date:	Mon, 25 Feb 2013 06:42:22 -0800
From:	Dave Hansen <dave@...ux.vnet.ibm.com>
To:	Peter Hurley <peter@...leysoftware.com>
CC:	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	Gleb Natapov <gleb@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	Marcelo Tosatti <mtosatti@...hat.com>,
	Rik van Riel <riel@...hat.com>
Subject: Re: [PATCH 0/5] [v3] fix illegal use of __pa() in KVM code

On 02/24/2013 01:28 PM, Peter Hurley wrote:
> Now that the alloc_remap() has been/is being removed, is most/all of
> this being reverted?

I _believe_ alloc_remap() is the only case where we actually remapped
low memory.  However, there is still other code that does __pa()
translations for percpu areas: per_cpu_ptr_to_phys().  I _think_ it's
still theoretically possible to get some percpu data in the vmalloc() area.

> So in short, my questions are:
> 1) is the slow_virt_to_phys() necessary anymore?

kvm_vcpu_arch has a

        struct pvclock_vcpu_time_info hv_clock;

and I believe I mistook the two 'hv_clock's for each other.  However,
this doesn't hurt anything, and the performance difference is probably
horribly tiny.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/