linux-kernel - Re: [PATCH] cpufreq: fix sign check of an unsigned variable in cpufreq-cpu0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130225184245.14870.87335@quantum>
Date:	Mon, 25 Feb 2013 10:42:45 -0800
From:	Mike Turquette <mturquette@...aro.org>
To:	Viresh Kumar <viresh.kumar@...aro.org>,
	Guennadi Liakhovetski <g.liakhovetski@....de>
Cc:	"Rafael J. Wysocki" <rjw@...k.pl>, cpufreq@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cpufreq: fix sign check of an unsigned variable in cpufreq-cpu0

Quoting Viresh Kumar (2013-02-25 04:09:47)
> On Mon, Feb 25, 2013 at 5:02 PM, Guennadi Liakhovetski
> <g.liakhovetski@....de> wrote:
> > A "< 0" test for an unsigned variable is meaningless, change the variable
> > to signed.
> >
> > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@....de>
> > ---
> >
> > stable?
> >
> >  drivers/cpufreq/cpufreq-cpu0.c |    3 ++-
> >  1 files changed, 2 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/cpufreq/cpufreq-cpu0.c b/drivers/cpufreq/cpufreq-cpu0.c
> > index 52bf36d..e7bad3c 100644
> > --- a/drivers/cpufreq/cpufreq-cpu0.c
> > +++ b/drivers/cpufreq/cpufreq-cpu0.c
> > @@ -44,7 +44,8 @@ static int cpu0_set_target(struct cpufreq_policy *policy,
> >  {
> >         struct cpufreq_freqs freqs;
> >         struct opp *opp;
> > -       unsigned long freq_Hz, volt = 0, volt_old = 0, tol = 0;
> > +       unsigned long volt = 0, volt_old = 0, tol = 0;
> > +       long freq_Hz;
> 
> Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
> 
> The disease is spread across a bigger region though.
> 
> @Mike: clk_round_rate returns long and __clk_round_rate returns unsigned long
> and clk_ops->round_rate returns long again.. Don't you see something
> strange here?

Yes, this is in my todo list.  I have a branch with some relevant
changes but I haven't posted it yet.

Regards,
Mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/