linux-kernel - Re: [PATCH v5 5/6] Input: matrix-keymap: Add function to read the new DT binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPnjgZ0r93Pzrj5bHFmM1BjkNzKLRVJoW=TGdvOHOwpgLbjv=Q@mail.gmail.com>
Date:	Mon, 25 Feb 2013 13:53:43 -0800
From:	Simon Glass <sjg@...omium.org>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Bill Pemberton <wfp5p@...ginia.edu>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Javier Martinez Canillas <javier@...hile0.org>,
	Sourav Poddar <sourav.poddar@...com>,
	Felipe Balbi <balbi@...com>,
	Alban Bedel <alban.bedel@...onic-design.de>,
	linux-input@...r.kernel.org
Subject: Re: [PATCH v5 5/6] Input: matrix-keymap: Add function to read the new
 DT binding

Hi Dmitry,

On Wed, Feb 20, 2013 at 10:18 AM, Dmitry Torokhov
<dmitry.torokhov@...il.com> wrote:
> On Wed, Feb 20, 2013 at 09:24:38AM -0800, Simon Glass wrote:
>> We now have a binding which adds two parameters to the matrix keypad DT
>> node. This is separate from the GPIO-driven matrix keypad binding, and
>> unfortunately incompatible, since that uses row-gpios/col-gpios for the
>> row and column counts.
>>
>> So the easiest option here is to provide a function for non-GPIO drivers
>> to use to decode the binding.
>>
>> Note: We could in fact create an entirely separate structure to hold
>> these two fields, but it does not seem worth it, yet. If we have more
>> parameters then we can add this, and then refactor each driver to hold
>> such a structure.
>>
>> Signed-off-by: Simon Glass <sjg@...omium.org>
>> Tested-by: Sourav Poddar <sourav.poddar@...com> (v2)
>
> Acked-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
>
> I suppose the EC driver will go through MFD tree, right?

Yes I expect so.

Regards,
Simon

>
> --
> Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/