[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1361761314.2303.9.camel@rzhang1-mobl4>
Date: Mon, 25 Feb 2013 11:01:54 +0800
From: Zhang Rui <rui.zhang@...el.com>
To: Peter Feuerer <peter@...e.net>
Cc: Borislav Petkov <bp@...en8.de>,
LKML <linux-kernel@...r.kernel.org>,
Durgadoss R <durgadoss.r@...el.com>,
Borislav Petkov <bp@...e.de>, Andreas Mohr <andi@...as.de>,
Alexander Lam <azl@...rew.cmu.edu>
Subject: Re: [PATCH] acerhdf: Fix fan activation with new thermal governor
On Sun, 2013-02-24 at 12:42 +0100, Peter Feuerer wrote:
> Hi Boris,
>
> thanks for your best wishes in the last mail, I'm feeling little better now.
>
> Borislav Petkov writes:
>
> > On Sat, Feb 23, 2013 at 08:20:10PM +0100, Borislav Petkov wrote:
> >> From: Borislav Petkov <bp@...e.de>
> >>
> >> The new step_wise thermal governor wasn't able to handle the one-trip
> >> point design of acerhdf where we want to turn off the fan if we go under
> >> the 'fanoff' temperature and to turn it on only after exceeding the
> >> 'fanon' temperature.
> >>
> >> Do that by looking at the current fan state and return the temperature
> >> accordingly.
> >>
> >> Suggested-by: Zhang Rui <rui.zhang@...el.com>
> >> Cc: Peter Feuerer <peter@...e.net>
> >> Cc: Andreas Mohr <andi@...as.de>
> >> Cc: Alexander Lam <azl@...rew.cmu.edu>
> >> Signed-off-by: Borislav Petkov <bp@...e.de>
> >
> > Ok, ignore this one for now - the suspend/resume path doesn't pan out
> > somehow, need to do some more handholding here.
>
> Please test my last patch with the 4 trip points ;) - even if you don't
> really like it, it is working great! - And to be honest, I still prefer this
> solution!
>
well, the 4 trip points do not make sense, at least the passive trip
point is a no op as we have no passive cooling device binded with it.
thanks,
rui
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists