linux-kernel - Re: [PATCH] x86, efi: Mark disable_runtime as _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <512BF9DA.2050906@jp.fujitsu.com>
Date:	Tue, 26 Feb 2013 08:55:06 +0900
From:	Satoru Takeuchi <takeuchi_satoru@...fujitsu.com>
To:	Matt Fleming <matt@...sole-pimps.org>
CC:	"H. Peter Anvin" <hpa@...ux.intel.com>,
	<linux-kernel@...r.kernel.org>, <linux-efi@...r.kernel.org>,
	Yinghai Lu <yinghai@...nel.org>,
	Matt Fleming <matt.fleming@...el.com>
Subject: Re: [PATCH] x86, efi: Mark disable_runtime as __initdata

(2013/02/23 0:03), Matt Fleming wrote:
> From: Matt Fleming <matt.fleming@...el.com>
> 
> disable_runtime is only referenced from __init functions, so mark it
> as __initdata.
> 
> Reported-by: Yinghai Lu <yinghai@...nel.org>
> Cc: Satoru Takeuchi <takeuchi_satoru@...fujitsu.com>
> Cc: H. Peter Anvin <hpa@...ux.intel.com>
> Signed-off-by: Matt Fleming <matt.fleming@...el.com>

It looks good to me.

Reviewed-by: Satoru Takeuchi <takeuchi_satoru@...fujitsu.com>

> ---
>  arch/x86/platform/efi/efi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c
> index 2f81db4..5ae99f9 100644
> --- a/arch/x86/platform/efi/efi.c
> +++ b/arch/x86/platform/efi/efi.c
> @@ -85,7 +85,7 @@ int efi_enabled(int facility)
>  }
>  EXPORT_SYMBOL(efi_enabled);
>  
> -static bool disable_runtime = false;
> +static bool __initdata disable_runtime = false;
>  static int __init setup_noefi(char *arg)
>  {
>  	disable_runtime = true;
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/