linux-kernel - [Question]CLOCK_EVT_NOTIFY_BROADCAST_EXIT must be called with interrupts disabled?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <27240C0AC20F114CBF8149A2696CBE4A23E2CB@SHSMSX101.ccr.corp.intel.com>
Date:	Tue, 26 Feb 2013 08:01:55 +0000
From:	"Liu, Chuansheng" <chuansheng.liu@...el.com>
To:	"tglx@...utronix.de" <tglx@...utronix.de>,
	"Ingo Molnar (mingo@...nel.org)" <mingo@...nel.org>
CC:	"'linux-kernel@...r.kernel.org' (linux-kernel@...r.kernel.org)" 
	<linux-kernel@...r.kernel.org>,
	"Liu, Chuansheng" <chuansheng.liu@...el.com>,
	"Chen, Jun D" <jun.d.chen@...el.com>
Subject: [Question]CLOCK_EVT_NOTIFY_BROADCAST_EXIT must be called with
 interrupts disabled?

Hi,

Just found some comments as below:
In commit 0beefa208bb3a9e581a60125703
+               /*
+                * The switch back from broadcast mode needs to be
+                * called with interrupts disabled.
+                */
+                local_irq_disable();
+                clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_EXIT, &cpu);
+                local_irq_enable();


But checked some place in kernel code, it likes below in intel_idle.c:
	local_irq_enable();

	if (!(lapic_timer_reliable_states & (1 << (cstate))))
		clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_EXIT, &cpu);
Which enable the irq at first, then calling CLOCK_EVT_NOTIFY_BROADCAST_EXIT.

So not sure _BROAD_EXIT must be called with interrupts disabled? Thanks your comments in advance.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/