linux-kernel - Re: [PATCH v5 7/8] v4l2: Add private controls base for SI476X

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201302260907.24281.hverkuil@xs4all.nl>
Date:	Tue, 26 Feb 2013 09:07:24 +0100
From:	Hans Verkuil <hverkuil@...all.nl>
To:	Andrey Smirnov <andrew.smirnov@...il.com>
Cc:	mchehab@...hat.com, sameo@...ux.intel.com, perex@...ex.cz,
	tiwai@...e.de, linux-media@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 7/8] v4l2: Add private controls base for SI476X

On Tue February 26 2013 07:38:53 Andrey Smirnov wrote:
> Add a base to be used for allocation of all the SI476X specific
> controls in the corresponding driver.
> 
> Signed-off-by: Andrey Smirnov <andrew.smirnov@...il.com>
> ---
>  include/uapi/linux/v4l2-controls.h |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h
> index 296d20e..133703d 100644
> --- a/include/uapi/linux/v4l2-controls.h
> +++ b/include/uapi/linux/v4l2-controls.h
> @@ -147,6 +147,10 @@ enum v4l2_colorfx {
>   * of controls. We reserve 16 controls for this driver. */
>  #define V4L2_CID_USER_MEYE_BASE			(V4L2_CID_USER_BASE + 0x1000)
>  
> +/* The base for the si476x driver controls. See include/media/si476x.h for the list
> + * of controls. */
> +#define V4L2_CID_USER_SI476X_BASE		(V4L2_CID_USER_BASE + 0x2000)

Please make this consecutive to MEYE_BASE, so '+ 0x1010'. That makes it easy
to keep track of these control ranges.

Regards,

	Hans

> +
>  /* MPEG-class control IDs */
>  
>  #define V4L2_CID_MPEG_BASE 			(V4L2_CTRL_CLASS_MPEG | 0x900)
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/