| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 26 Feb 2013 10:03:15 +0100 From: Samuel Iglesias Gonsalvez <siglesias@...lia.com> To: Greg Kroah-Hartman <gregkh@...uxfoundation.org> Cc: Jens Taprogge <jens.taprogge@...rogge.org>, industrypack-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org, Samuel Iglesias Gonsalvez <siglesias@...lia.com> Subject: [PATCH] ipack: add missing put_device() after device_register() failed put_device() must be called after device_register() fails, since device_register() always initializes the refcount on the device structure to one. dev->id is free'd inside of ipack_device_release function. So, it's not needed to do it here. Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@...lia.com> --- drivers/ipack/ipack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ipack/ipack.c b/drivers/ipack/ipack.c index 7ec6b20..3588ccf 100644 --- a/drivers/ipack/ipack.c +++ b/drivers/ipack/ipack.c @@ -449,7 +449,7 @@ int ipack_device_register(struct ipack_device *dev) ret = device_register(&dev->dev); if (ret < 0) - kfree(dev->id); + put_device(&dev->dev); return ret; } -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists