linux-kernel - Re: I2C: Fix i2c fail problem when a process is terminated by a signal on octeon in 3.8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1302261101250.2128@pobox.suse.cz>
Date:	Tue, 26 Feb 2013 11:02:17 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	јЫАєєА <eunb.song@...sung.com>
Cc:	linux-kernel@...r.kernel.org, Wolfram Sang <wsa@...-dreams.de>,
	"Ben Dooks (embedded platforms)" <ben-linux@...ff.org>,
	linux-i2c@...r.kernel.org
Subject: Re: I2C: Fix i2c fail problem when a process is terminated by a
 signal on octeon  in 3.8

On Fri, 22 Feb 2013, м†ЎмќЂлґ‰ wrote:

> 
> В 
> 
> I've been debugging the abnormal operation of i2c on octeon.
> If a process is terminated by signal in the middle of i2c operation,
> next i2c read operation which is done by another process was failed.
> So i changed to ignore signal in the middle of i2c operation.
> After that the problem was not reproduced.

This is not really material directly for trivial.git. Adding maintainers 
to CC.

> 
> В 
> 
> Signed-off-by: EunBong Song <eunb.song@...sung.com>
> 
> diff -up drivers/i2c/busses/i2c-octeon.c{.orig,}
> --- drivers/i2c/busses/i2c-octeon.c.origВ 2013-02-21 08:09:03.168018843 -0800
> +++ drivers/i2c/busses/i2c-octeon.cВ 2013-02-21 08:09:38.344018898 -0800
> @@ -183,7 +183,7 @@ static irqreturn_t octeon_i2c_isr(int ir
> В В struct octeon_i2c *i2c = dev_id;
> В 
> В В octeon_i2c_int_disable(i2c);
> -В wake_up_interruptible(&i2c->queue);
> +В wake_up(&i2c->queue);
> В 
> В В return IRQ_HANDLED;
> В }
> @@ -206,7 +206,7 @@ static int octeon_i2c_wait(struct octeon
> В 
> В В octeon_i2c_int_enable(i2c);
> В 
> -В result = wait_event_interruptible_timeout(i2c->queue,
> +В result = wait_event_timeout(i2c->queue,
> В В В В В В В В  octeon_i2c_test_iflg(i2c),
> В В В В В В В В  i2c->adap.timeout);
> 
> В 
> 
> В 
> 
> [IMAGE]
> 
> [SeenTimeChecker?do=5c4ee24ec3c4b5ef0b1e1d188d51662fbee53716e9d11aa47790d17410439b26f5961395f090d04f94a68828d2d0a033db9fdddda33
> e82cbe4a391424e62fcf6cf878f9a26ce15a0]
> 

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/