linux-kernel - Re: [PATCH] mfd: palmas: is_palmas_charger needed by multiple drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <512CC021.4060201@nvidia.com>
Date:	Tue, 26 Feb 2013 19:31:05 +0530
From:	Laxman Dewangan <ldewangan@...dia.com>
To:	Ian Lartey <ian@...mlogic.co.uk>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"grant.likely@...retlab.ca" <grant.likely@...retlab.ca>,
	"linus.walleij@...aro.org" <linus.walleij@...aro.org>,
	"sameo@...ux.intel.com" <sameo@...ux.intel.com>,
	Graeme Gregory <gg@...mlogic.co.uk>
Subject: Re: [PATCH] mfd: palmas: is_palmas_charger needed by multiple drivers

On Tuesday 26 February 2013 06:46 PM, Ian Lartey wrote:
> is_palmas_charger checks for the presence of charging
> functionality in the device
>
> Signed-off-by: Graeme Gregory <gg@...mlogic.co.uk>
> Signed-off-by: Ian Lartey <ian@...mlogic.co.uk>
> ---
>   include/linux/mfd/palmas.h |    5 +++++
>   1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/mfd/palmas.h b/include/linux/mfd/palmas.h
> index 3129f9a..98c0567 100644
> --- a/include/linux/mfd/palmas.h
> +++ b/include/linux/mfd/palmas.h
> @@ -26,6 +26,11 @@
>   /* The ID_REVISION NUMBERS */
>   #define PALMAS_CHIP_OLD_ID		0x0000
>   #define PALMAS_CHIP_ID			0xC035
> +#define PALMAS_CHIP_CHARGER_ID		0xC036
> +
> +#define is_palmas(a)	(((a) == PALMAS_CHIP_OLD_ID) || \
> +			((a) == PALMAS_CHIP_ID))
> +#define is_palmas_charger(a) ((a) == PALMAS_CHIP_CHARGER_ID)
>   

TI says this as TPS80036 and original palma as TPS65913/TPS65914. Not 
sure whether palma_charger is correct or not here.

But above change looks good.

Acked-by: Laxman Dewangan<ldewangan@...dia.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/