linux-kernel - Re: [PATCH V2] rtc: add devm_rtc_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <008f01ce13c2$7c9e37d0$75daa770$%han@samsung.com>
Date:	Tue, 26 Feb 2013 10:42:07 +0900
From:	Jingoo Han <jg1.han@...sung.com>
To:	'Tejun Heo' <tj@...nel.org>
Cc:	'Andrew Morton' <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, 'Greg KH' <greg@...ah.com>,
	'Alessandro Zummo' <a.zummo@...ertech.it>,
	rtc-linux@...glegroups.com, 'Jingoo Han' <jg1.han@...sung.com>
Subject: Re: [PATCH V2] rtc: add devm_rtc_device_{register,unregister}()

On Tuesday, February 26, 2013 10:30 AM, Tejun Heo wrote:
> 
> On Mon, Feb 25, 2013 at 05:23:17PM -0800, 'Tejun Heo' wrote:
> > again, why do we need the WARN_ON() at all given that other
> > devm_*_match() don't do that and the only way to get NULL there would
> > be bug in devm_rtc*() code itself rather than its users?
> 
> Ughh... I see that you probably copied the chunk from clk / regulator
> implementation.  Let's please not copy those.  Input validation via
> WARN_ON()s is nice when the interface is taking input from outside or
> the code in question is complex / fragile.  Here, the code involved is
> like 20 lines and self-contained.

OK, I see.
Thank you for your comment.
I will send v3 patch soon :)

Best regards,
Jingoo Han

> 
> Thanks.
> 
> --
> tejun

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/