| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20130226014810.GI2679@htj.dyndns.org> Date: Mon, 25 Feb 2013 17:48:10 -0800 From: Tejun Heo <tj@...nel.org> To: Peter Hurley <peter@...leysoftware.com> Cc: Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org Subject: Re: [PATCH] idr: Don't WARN in idr_find On Mon, Feb 25, 2013 at 08:46:11PM -0500, Peter Hurley wrote: > On Mon, 2013-02-25 at 17:40 -0800, Tejun Heo wrote: > > On Mon, Feb 25, 2013 at 08:37:12PM -0500, Peter Hurley wrote: > > > Since idr is used for syscall apis (to associate 'handles' with > > > internal structures), don't WARN with invalid input. > > > > > > For example, POSIX timers are identified by timer_t id. These > > > ids are idr values. If userspace passes a representable timer_t id > > > value (eg, id < 0) but which was not previous allocated (since the > > > current idr api does not return negative idr values), then the > > > syscall properly returns an error; a WARN is unnecessary and > > > undesirable. > > > > WARN_ON() on negative was intentional. Because the previous > > implmentation silently dropped the msb, we at least wanna know who has > > been passing in negative indices. Patch for the lock_timer is already > > in -mm. > > Thanks. Can you share the patch title? It's not in next-20130225. It's this one. http://thread.gmane.org/gmane.linux.kernel/1444883/focus=1445094 Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists