linux-kernel - Re: [PATCH] fusb300_udc: modify stall clear and idma reset procedure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130226175910.GD1225@arwen.pp.htv.fi>
Date:	Tue, 26 Feb 2013 19:59:10 +0200
From:	Felipe Balbi <balbi@...com>
To:	Yuan-Hsin Chen <yuanlmm@...il.com>
CC:	<balbi@...com>, <gregkh@...uxfoundation.org>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	Yuan-Hsin Chen <yhchen@...aday-tech.com>
Subject: Re: [PATCH] fusb300_udc: modify stall clear and idma reset procedure

Hi,

On Fri, Feb 22, 2013 at 07:09:39AM +0000, Yuan-Hsin Chen wrote:
> From: Yuan-Hsin Chen <yuanlmm@...il.com>
> 
> Due to fusb300 controller modification, stall clear procedure should be
> modified consistantly. This patch also fixes software bugs: only
> enter IDMA_RESET when the condition matched and disable corresponding
> PRD interrupt in IDMA_RESET.
> 
> 
> Signed-off-by: Yuan-Hsin Chen <yhchen@...aday-tech.com>

I have been trying to understand if this is a bug fix or if it can wait
until v3.10.

Also, according to your commit log, it seems like this patch is doing
more than one thing, which is really frowned upon. Please split it up
into separate logically self-contained changes. While doing that, make
sure that your commit log explains the problem and the solution very
well. Saying that because of a controller modification you need to
change stall clear consistently isn't enough.

Don't forget to mention how and with which platforms you tested.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)