linux-kernel - Re: [PATCH 3.9-rc1] clk: vt8500: Fix variable name '*prate' compile error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 26 Feb 2013 11:29:58 -0800
From:	Mike Turquette <mturquette@...aro.org>
To:	Tim Gardner <tim.gardner@...onical.com>,
	linux-kernel@...r.kernel.org
Cc:	Tim Gardner <tim.gardner@...onical.com>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 3.9-rc1] clk: vt8500: Fix variable name '*prate' compile error

Quoting Tim Gardner (2013-02-26 09:34:12)
> commit 72480014b86c8b51fb51c5c6a0525876055c37c7 (clk: vt8500: Fix device clock
> divisor calculations) introduced a compile error in the naming of a variable in
> vt8500_dclk_set_rate(). It looks like a simple cut and paste error.
> 
> Cc: Mike Turquette <mturquette@...aro.org>
> Cc: linux-arm-kernel@...ts.infradead.org
> Signed-off-by: Tim Gardner <tim.gardner@...onical.com>

Tim,

Thanks for the fix.  I already have a fix for this issue in my clk-fixes
branch.  In fact I forgot to bundle this one and another mxs fix in my
3.9 pull request so I'll send a follow-up bugfix branch after 3.9-rc1 is
out.

Regards,
Mike

> ---
>  drivers/clk/clk-vt8500.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/clk-vt8500.c b/drivers/clk/clk-vt8500.c
> index b5538bb..09c6331 100644
> --- a/drivers/clk/clk-vt8500.c
> +++ b/drivers/clk/clk-vt8500.c
> @@ -157,7 +157,7 @@ static int vt8500_dclk_set_rate(struct clk_hw *hw, unsigned long rate,
>         divisor =  parent_rate / rate;
>  
>         /* If prate / rate would be decimal, incr the divisor */
> -       if (rate * divisor < *prate)
> +       if (rate * divisor < parent_rate)
>                 divisor++;
>  
>         if (divisor == cdev->div_mask + 1)
> -- 
> 1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/