linux-kernel - Re: [PATCH] PM / OPP: improve introductory documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <512D47AB.9030401@infradead.org>
Date:	Tue, 26 Feb 2013 15:39:23 -0800
From:	Randy Dunlap <rdunlap@...radead.org>
To:	Nishanth Menon <nm@...com>
CC:	linux-pm <linux-pm@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PM / OPP: improve introductory documentation

On 02/26/13 15:10, Nishanth Menon wrote:
> On 14:43-20130226, Randy Dunlap wrote:
>> On 02/26/13 09:37, Nishanth Menon wrote:
> [..]
>>>  
>>>  1. Introduction
>>>  ===============
>>> +1.1 What is an Operating Performance Point (OPP)?
>>> +
>>>  Complex SoCs of today consists of a multiple sub-modules working in conjunction.
>>>  In an operational system executing varied use cases, not all modules in the SoC
>>>  need to function at their highest performing frequency all the time. To
>>>  facilitate this, sub-modules in a SoC are grouped into domains, allowing some
>>>  domains to run at lower voltage and frequency while other domains are loaded
>>> -more. The set of discrete tuples consisting of frequency and voltage pairs that
>>> +more.
>>
>> huh???
> I split the definition line to it's own paragraph below. But, I think
> you intend to say we could improve better the remaining paragraph.
> Could you elaborate your thoughts?

"while other domains are loaded more."  Some people probably understand
that OK; I dunno.  I would rather see it written out more verbosely, e.g.:

"while other domains run at voltage/frequency pairs that are higher."

but partly I was confused by the diff(1) lines.  my bad :(


>>> +
>>> +The set of discrete tuples consisting of frequency and voltage pairs that
>>>  the device will support per domain are called Operating Performance Points or
>>>  OPPs.
>>>  
>>> +As an example:
>>> +Let us consider an MPU device which supports the following:
>>> +{300MHz at minimum voltage of 1V}, {800MHz at minimum voltage of 1.2V},
>>> +{1GHz at minimum voltage of 1.3V}
>>> +
>>> +We can represent these as three OPPs as the following {Hz, uV} tuples:
>>> +{300000000, 1000000}
>>> +{600000000, 1200000}
>>     800000000
>>
>>> +{100000000, 1300000}
>>     1000000000 ??
> Thanks for catching it. will fix it in next rev.
> 


-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/