linux-kernel - Re: [PATCH 2/2] f2fs: introduce readahead mode of node pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <1361927080.31428.25.camel@kjgkr>
Date:	Wed, 27 Feb 2013 10:04:40 +0900
From:	Jaegeuk Kim <jaegeuk.kim@...sung.com>
To:	Namjae Jeon <linkinjeon@...il.com>
Cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-f2fs-devel@...ts.sourceforge.net
Subject: Re: [PATCH 2/2] f2fs: introduce readahead mode of node pages

2013-02-26 (화), 20:52 +0900, Namjae Jeon:
> > @@ -434,7 +434,7 @@ int get_dnode_of_data(struct dnode_of_data *dn, pgoff_t
> > index, int ro)
> >  			alloc_nid_done(sbi, nids[i]);
> >  			mutex_unlock_op(sbi, NODE_NEW);
> >  			done = true;
> > -		} else if (ro && i == level && level > 1) {
> > +		} else if (mode == LOOKUP_NODE_RA && i == level && level > 1) {
> >  			npage[i] = get_node_page_ra(parent, offset[i - 1]);
> >  			if (IS_ERR(npage[i])) {
> >  				err = PTR_ERR(npage[i]);
> 
> Hi Jaegeuk.
> There is no LOOKUP_NODE usage in this patch.
> I think that we can use LOOKUP_NODE flag instead of done(bool)  like this.
>  if (mode == LOOKUP_NODE)

Hi.
In order to do that, we should check additional conditions like i and
level together with mode == LOOKUP_NODE.
So, I'm not sure how much it makes clearer by using LOOKUP_NODE
explicitly.
It seems fine to me, since we can just use LOOKUP_NODE to distinguish it
from the other modes.
Any thought?

-- 
Jaegeuk Kim
Samsung

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)