linux-kernel - Re: [PATCH] regulator: palmas: use correct device node for DT parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <512E16EE.2050201@slimlogic.co.uk>
Date:	Wed, 27 Feb 2013 14:23:42 +0000
From:	Graeme Gregory <gg@...mlogic.co.uk>
To:	Laxman Dewangan <ldewangan@...dia.com>
CC:	broonie@...nsource.wolfsonmicro.com, linux-kernel@...r.kernel.org,
	swarren@...dia.com, ian@...mlogic.co.uk, lrg@...com
Subject: Re: [PATCH] regulator: palmas: use correct device node for DT parsing

On 27/02/13 14:10, Laxman Dewangan wrote:
> When device is registered through the DT then regulators node
> exist in the parent device node of regulator driver. Hence passing
> parent device node for parsing DT in place of self-device node
> which is typically NULL.
>
> Signed-off-by: Laxman Dewangan <ldewangan@...dia.com>
> ---
>  drivers/regulator/palmas-regulator.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/regulator/palmas-regulator.c b/drivers/regulator/palmas-regulator.c
> index e915629..f07501d 100644
> --- a/drivers/regulator/palmas-regulator.c
> +++ b/drivers/regulator/palmas-regulator.c
> @@ -591,7 +591,7 @@ static int palmas_probe(struct platform_device *pdev)
>  {
>  	struct palmas *palmas = dev_get_drvdata(pdev->dev.parent);
>  	struct palmas_pmic_platform_data *pdata = pdev->dev.platform_data;
> -	struct device_node *node = pdev->dev.of_node;
> +	struct device_node *node = pdev->dev.parent->of_node;
>  	struct regulator_dev *rdev;
>  	struct regulator_config config = { };
>  	struct palmas_pmic *pmic;
This is not correct, nor is the reasoning.

I suspect your previous patch broke DT probing so your not getting nodes
filled in.

Graeme

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/