lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20130227151752.GB10908@oc6784271780.ibm.com>
Date:	Wed, 27 Feb 2013 09:17:52 -0600
From:	"Philip J. Kelleher" <pjk1939@...ux.vnet.ibm.com>
To:	Joe Perches <joe@...ches.com>
Cc:	axboe@...nel.dk, linux-kernel@...r.kernel.org,
	brking@...ux.vnet.ibm.com, josh.h.morris@...ibm.com
Subject: Re: [PATCH 3/4] block: IBM RamSan 70/80 branding changes.

Thanks for your response. Comment inline.

I send a new patch soon.

On Mon, Feb 25, 2013 at 12:07:34PM -0800, Joe Perches wrote:
> On Mon, 2013-02-25 at 12:58 -0600, Philip J. Kelleher wrote:
> > From: Philip J Kelleher <pjk1939@...ux.vnet.ibm.com>
> > 
> > This patch includes changing the hardware branding name from
> > IBM RamSan to IBM FlashSystem.
> 
> just a trivial comment
> 
> > diff -uprN -X linux-block-vanilla/Documentation/dontdiff linux-block-vanilla/drivers/block/rsxx/rsxx_priv.h linux-block/drivers/block/rsxx/rsxx_priv.h
> []
> > @@ -45,16 +45,14 @@
> >  
> >  struct proc_cmd;
> >  
> > -#define PCI_VENDOR_ID_TMS_IBM		0x15B6
> > -#define PCI_DEVICE_ID_RS70_FLASH	0x0019
> > -#define PCI_DEVICE_ID_RS70D_FLASH	0x001A
> > -#define PCI_DEVICE_ID_RS80_FLASH	0x001C
> > -#define PCI_DEVICE_ID_RS81_FLASH	0x001E
> > +#define PCI_VENDOR_ID_IBM		0x1014
> 
> PCI_VENDOR_ID_IBM is already #defined in pci_ids.h
> 
> 

Alright.... good to know. Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ