linux-kernel - Re: [PATCH] drivers/block/xen-blkback: preq.dev is used without initialized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130227154002.GE24932@phenom.dumpdata.com>
Date:	Wed, 27 Feb 2013 10:40:02 -0500
From:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To:	Jan Beulich <JBeulich@...e.com>
Cc:	Chen Gang <gang.chen@...anux.com>, roger.pau@...rix.com,
	stefano.stabellini@...citrix.com,
	xen-devel <xen-devel@...ts.xen.org>, dgdegra@...ho.nsa.gov,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers/block/xen-blkback: preq.dev is used without
 initialized

On Wed, Feb 27, 2013 at 10:45:35AM +0000, Jan Beulich wrote:
> >>> On 27.02.13 at 11:38, Chen Gang <gang.chen@...anux.com> wrote:
> > 于 2013年02月27日 17:57, Jan Beulich 写道:
> >> You also could have mentioned that even before commit 
> >> 01c681d4c70d64cb72142a2823f27c4146a02e63 the value printed
> >> here was bogus, as it was the guest provided value from
> >> req->u.rw.handle rather than the actual device.
> > 
> >   pardon ?
> > 
> >   I guess what you said is :
> >     my patch seems ok, but the comments need improving.
> >     need add "additional info" in comments:
> >       "before commit 01c681d4c70d64cb72142a2823f27c4146a02e63
> >        the value printed here was bogus, as it was the guest
> >        provided value from req->u.rw.handle rather than the
> >        actual device".
> > 
> >   is it correct ?
> 
> Yes (and you might have missed the ACK that I had already sent
> before this reply - that mail got bounced for your address).

Yup. Chen, could you respin the patch with the extra comment and
the Ack from Jan please?

Thank you!
> 
> Jan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/