linux-kernel - Re: [PATCH 1/3] libfdt: add fdt type definitions in libfdt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <512E3CD4.6000305@gmail.com>
Date:	Wed, 27 Feb 2013 11:05:24 -0600
From:	Rob Herring <robherring2@...il.com>
To:	Kim Phillips <kim.phillips@...escale.com>
CC:	Grant Likely <grant.likely@...retlab.ca>,
	Russell King <linux@....linux.org.uk>,
	devicetree-discuss@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	Nicolas Pitre <nico@...aro.org>
Subject: Re: [PATCH 1/3] libfdt: add fdt type definitions in libfdt_env.h

On 02/26/2013 07:36 PM, Kim Phillips wrote:
> in preparation for the forthcoming dtc update which adds fdt specific
> types: fdt{16,32,64}_t.
> 
> Signed-off-by: Kim Phillips <kim.phillips@...escale.com>
> ---
>  arch/arm/boot/compressed/libfdt_env.h | 4 ++++
>  include/linux/libfdt_env.h            | 6 ++++++

We should kill off arch/arm/boot/compressed/libfdt_env.h and use
include/linux/libfdt_env.h instead. The only reason I see why we have
both is the ARM version was introduced before include/linux/libfdt_env.h
existed.

Rob

>  2 files changed, 10 insertions(+)
> 
> diff --git a/arch/arm/boot/compressed/libfdt_env.h b/arch/arm/boot/compressed/libfdt_env.h
> index 1f4e718..17ae0f3 100644
> --- a/arch/arm/boot/compressed/libfdt_env.h
> +++ b/arch/arm/boot/compressed/libfdt_env.h
> @@ -5,6 +5,10 @@
>  #include <linux/string.h>
>  #include <asm/byteorder.h>
>  
> +typedef __be16 fdt16_t;
> +typedef __be32 fdt32_t;
> +typedef __be64 fdt64_t;
> +
>  #define fdt16_to_cpu(x)		be16_to_cpu(x)
>  #define cpu_to_fdt16(x)		cpu_to_be16(x)
>  #define fdt32_to_cpu(x)		be32_to_cpu(x)
> diff --git a/include/linux/libfdt_env.h b/include/linux/libfdt_env.h
> index 01508c7..da98097 100644
> --- a/include/linux/libfdt_env.h
> +++ b/include/linux/libfdt_env.h
> @@ -5,6 +5,12 @@
>  
>  #include <asm/byteorder.h>
>  
> +typedef __be16 fdt16_t;
> +typedef __be32 fdt32_t;
> +typedef __be64 fdt64_t;
> +
> +#define fdt16_to_cpu(x) be16_to_cpu(x)
> +#define cpu_to_fdt16(x) cpu_to_be16(x)
>  #define fdt32_to_cpu(x) be32_to_cpu(x)
>  #define cpu_to_fdt32(x) cpu_to_be32(x)
>  #define fdt64_to_cpu(x) be64_to_cpu(x)
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/