linux-kernel - Re: [PATCH 3/4] regulator: palmas: Removing duplicated code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 Feb 2013 11:35:16 -0700
From:	Stephen Warren <swarren@...dotorg.org>
To:	J Keerthy <j-keerthy@...com>
CC:	broonie@...nsource.wolfsonmicro.com, lgirdwood@...il.com,
	linux-kernel@...r.kernel.org, gg@...mlogic.co.uk
Subject: Re: [PATCH 3/4] regulator: palmas: Removing duplicated code

On 02/17/2013 10:14 PM, J Keerthy wrote:
> Removing duplicate assignment in the existing code.
...
> diff --git a/drivers/regulator/palmas-regulator.c b/drivers/regulator/palmas-regulator.c
...
> @@ -566,11 +566,6 @@ static void palmas_dt_to_pdata(struct device *dev,
>  			pdata->reg_init[idx]->mode_sleep = prop;
>  
>  		ret = of_property_read_u32(palmas_matches[idx].of_node,
> -				"ti,warm_reset", &prop);
> -		if (!ret)
> -			pdata->reg_init[idx]->warm_reset = prop;
> -
> -		ret = of_property_read_u32(palmas_matches[idx].of_node,

Can you point out where the duplicate of that is; I don't see any other
assignment to warm_reset.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/