linux-kernel - Re: [patch v5 02/15] sched: set initial load avg of new forked task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <512F0139.60702@linux.vnet.ibm.com>
Date:	Thu, 28 Feb 2013 12:33:21 +0530
From:	Preeti U Murthy <preeti@...ux.vnet.ibm.com>
To:	Alex Shi <alex.shi@...el.com>
CC:	torvalds@...ux-foundation.org, mingo@...hat.com,
	peterz@...radead.org, tglx@...utronix.de,
	akpm@...ux-foundation.org, arjan@...ux.intel.com, bp@...en8.de,
	pjt@...gle.com, namhyung@...nel.org, efault@....de,
	vincent.guittot@...aro.org, gregkh@...uxfoundation.org,
	viresh.kumar@...aro.org, linux-kernel@...r.kernel.org,
	morten.rasmussen@....com
Subject: Re: [patch v5 02/15] sched: set initial load avg of new forked task

Hi Alex,

>>> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
>>> index 81fa536..cae5134 100644
>>> --- a/kernel/sched/fair.c
>>> +++ b/kernel/sched/fair.c
>>> @@ -1509,6 +1509,10 @@ static inline void enqueue_entity_load_avg(struct cfs_rq *cfs_rq,
>>>  	 * We track migrations using entity decay_count <= 0, on a wake-up
>>>  	 * migration we use a negative decay count to track the remote decays
>>>  	 * accumulated while sleeping.
>>> +	 *
>>> +	 * When enqueue a new forked task, the se->avg.decay_count == 0, so
>>> +	 * we bypass update_entity_load_avg(), use avg.load_avg_contrib initial
>>> +	 * value: se->load.weight.
>>
>> I disagree with the comment.update_entity_load_avg() gets called for all
>> forked tasks.
>> enqueue_task_fair->update_entity_load_avg() during the second
>> iteration.But __update_entity_load_avg() in update_entity_load_avg()
>>
> 
> When goes 'enqueue_task_fair->update_entity_load_avg()' during the
> second iteration. the se is changed.
> That is different se.
> 
> 
Correct Alex,sorry I overlooked this.

Regards
Preeti U Murthy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/