linux-kernel - [PATCH 08/19] rtc: rtc-coh901331: remove erroneous __init/_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <00ac01ce158f$719219f0$54b64dd0$%han@samsung.com>
Date:	Thu, 28 Feb 2013 17:41:46 +0900
From:	Jingoo Han <jg1.han@...sung.com>
To:	'Andrew Morton' <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org,
	'Alessandro Zummo' <a.zummo@...ertech.it>,
	rtc-linux@...glegroups.com, 'Jingoo Han' <jg1.han@...sung.com>
Subject: [PATCH 08/19] rtc: rtc-coh901331: remove erroneous __init/__exit
 annotations

__init/__exit annotations for probe()/remove() are supposed to be
__devinit/__devexit, because __init/__exit for probe()/remove()
are not correct. However, __devinit/__devexit are not used,
because CONFIG_HOTPLUG was removed. Thus, these annotations
should be removed.

Signed-off-by: Jingoo Han <jg1.han@...sung.com>
---
 drivers/rtc/rtc-coh901331.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/rtc/rtc-coh901331.c b/drivers/rtc/rtc-coh901331.c
index 2d28ec1..a166a37 100644
--- a/drivers/rtc/rtc-coh901331.c
+++ b/drivers/rtc/rtc-coh901331.c
@@ -150,7 +150,7 @@ static struct rtc_class_ops coh901331_ops = {
 	.alarm_irq_enable = coh901331_alarm_irq_enable,
 };
 
-static int __exit coh901331_remove(struct platform_device *pdev)
+static int coh901331_remove(struct platform_device *pdev)
 {
 	struct coh901331_port *rtap = dev_get_drvdata(&pdev->dev);
 
@@ -164,7 +164,7 @@ static int __exit coh901331_remove(struct platform_device *pdev)
 }
 
 
-static int __init coh901331_probe(struct platform_device *pdev)
+static int coh901331_probe(struct platform_device *pdev)
 {
 	int ret;
 	struct coh901331_port *rtap;
@@ -281,7 +281,7 @@ static struct platform_driver coh901331_driver = {
 		.name = "rtc-coh901331",
 		.owner = THIS_MODULE,
 	},
-	.remove = __exit_p(coh901331_remove),
+	.remove = coh901331_remove,
 	.suspend = coh901331_suspend,
 	.resume = coh901331_resume,
 	.shutdown = coh901331_shutdown,
-- 
1.7.2.5


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/