lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-id: <00ae01ce158f$92a7a510$b7f6ef30$%han@samsung.com>
Date:	Thu, 28 Feb 2013 17:42:42 +0900
From:	Jingoo Han <jg1.han@...sung.com>
To:	'Andrew Morton' <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org,
	'Alessandro Zummo' <a.zummo@...ertech.it>,
	rtc-linux@...glegroups.com, 'Jingoo Han' <jg1.han@...sung.com>
Subject: [PATCH 10/19] rtc: rtc-rp5c01: remove erroneous __init/__exit
 annotations

__init/__exit annotations for probe()/remove() are supposed to be
__devinit/__devexit, because __init/__exit for probe()/remove()
are not correct. However, __devinit/__devexit are not used,
because CONFIG_HOTPLUG was removed. Thus, these annotations
should be removed.

Signed-off-by: Jingoo Han <jg1.han@...sung.com>
---
 drivers/rtc/rtc-rp5c01.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/rtc/rtc-rp5c01.c b/drivers/rtc/rtc-rp5c01.c
index 359da6d..da4f6c4 100644
--- a/drivers/rtc/rtc-rp5c01.c
+++ b/drivers/rtc/rtc-rp5c01.c
@@ -219,7 +219,7 @@ static ssize_t rp5c01_nvram_write(struct file *filp, struct kobject *kobj,
 	return count;
 }
 
-static int __init rp5c01_rtc_probe(struct platform_device *dev)
+static int rp5c01_rtc_probe(struct platform_device *dev)
 {
 	struct resource *res;
 	struct rp5c01_priv *priv;
@@ -275,7 +275,7 @@ out_free_priv:
 	return error;
 }
 
-static int __exit rp5c01_rtc_remove(struct platform_device *dev)
+static int rp5c01_rtc_remove(struct platform_device *dev)
 {
 	struct rp5c01_priv *priv = platform_get_drvdata(dev);
 
@@ -291,7 +291,7 @@ static struct platform_driver rp5c01_rtc_driver = {
 		.name	= "rtc-rp5c01",
 		.owner	= THIS_MODULE,
 	},
-	.remove	= __exit_p(rp5c01_rtc_remove),
+	.remove	= rp5c01_rtc_remove,
 };
 
 static int __init rp5c01_rtc_init(void)
-- 
1.7.2.5


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ