linux-kernel - Re: [PATCH 01/19] rtc: rtc-mv: remove erroneous _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-id: <000701ce1597$cf15a3f0$6d40ebd0$%han@samsung.com>
Date:	Thu, 28 Feb 2013 18:41:39 +0900
From:	Jingoo Han <jg1.han@...sung.com>
To:	'Andrew Morton' <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org,
	'Alessandro Zummo' <a.zummo@...ertech.it>,
	rtc-linux@...glegroups.com,
	'Geert Uytterhoeven' <geert@...ux-m68k.org>,
	'Jingoo Han' <jg1.han@...sung.com>
Subject: Re: [PATCH 01/19] rtc: rtc-mv: remove erroneous __exit annotation

On Thursday, February 28, 2013 5:38 PM, Jingoo Han wrote:
> 
> __init/__exit annotations for probe()/remove() are supposed to be
> __devinit/__devexit, because __init/__exit for probe()/remove()
> are not correct. However, __devinit/__devexit are not used,
> because CONFIG_HOTPLUG was removed. Thus, these annotations
> should be removed.
> 

Hi Andrew,

As Geert Uytterhoeven mentioned, the patchset is useless
because the drivers I sent for use platform_driver_probe().

Please, abandon all patchset that I sent.
Thank you.


Best regards,
Jingoo Han


> Signed-off-by: Jingoo Han <jg1.han@...sung.com>
> ---
>  drivers/rtc/rtc-mv.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-mv.c b/drivers/rtc/rtc-mv.c
> index 57233c8..8cb15d2 100644
> --- a/drivers/rtc/rtc-mv.c
> +++ b/drivers/rtc/rtc-mv.c
> @@ -284,7 +284,7 @@ static int mv_rtc_probe(struct platform_device *pdev)
>  	return 0;
>  }
> 
> -static int __exit mv_rtc_remove(struct platform_device *pdev)
> +static int mv_rtc_remove(struct platform_device *pdev)
>  {
>  	struct rtc_plat_data *pdata = platform_get_drvdata(pdev);
> 
> @@ -303,7 +303,7 @@ static struct of_device_id rtc_mv_of_match_table[] = {
>  #endif
> 
>  static struct platform_driver mv_rtc_driver = {
> -	.remove		= __exit_p(mv_rtc_remove),
> +	.remove		= mv_rtc_remove,
>  	.driver		= {
>  		.name	= "rtc-mv",
>  		.owner	= THIS_MODULE,
> --
> 1.7.2.5


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/