linux-kernel - Re: [PATCH 1/5] staging: android: lowmemorykiller: Add config option to support oom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMP5XgdE-Ui9qiLGjvAXk13LbCzn-bHEC_AsxQ8dWpz+R-qSDg@mail.gmail.com>
Date:	Wed, 27 Feb 2013 17:05:01 -0800
From:	Arve Hjønnevåg <arve@...roid.com>
To:	David Rientjes <rientjes@...gle.com>
Cc:	John Stultz <john.stultz@...aro.org>,
	lkml <linux-kernel@...r.kernel.org>,
	Android Kernel Team <kernel-team@...roid.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 1/5] staging: android: lowmemorykiller: Add config option
 to support oom_adj values

On Wed, Feb 27, 2013 at 4:14 PM, David Rientjes <rientjes@...gle.com> wrote:
> On Wed, 27 Feb 2013, Arve Hjønnevåg wrote:
>
>> Because, without this patch, the values written to
>> /sys/module/lowmemorykiller/parameters/adj do not get adjusted and
>> therefore do not match the correct processes.
>>
>
> Explain how this can possibly be consistent if your system includes two
> processes, one writing oom_adj values and one writing oom_score_adj
> values, and the kernel has this new option enabled?

These values are all written by the same process. If you want to
improve this, the lowmemorykiller will need a separate score_adj
parameter so that it knows for sure which type of value it receives.
You changed the meaning of /sys/module/lowmemorykiller/parameters/adj.
This patch restores the old behavior as long as the values you write
are within the range oom_adj, while still supporting the new behavior
you added in the likely case that one of the values are out of range
for oom_adj.

-- 
Arve Hjønnevåg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/