linux-kernel - [PATCH] menuconfig: use config scripts to detect ncurses libs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1362052335-17913-1-git-send-email-jlec@gentoo.org>
Date:	Thu, 28 Feb 2013 12:52:15 +0100
From:	jlec@...too.org
To:	linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:	Justin Lecher <jlec@...too.org>
Subject: [PATCH] menuconfig: use config scripts to detect ncurses libs

From: Justin Lecher <jlec@...too.org>

When building ncurses with --with-termlib several symbols get moved from
libncurses.so to libtinfo.so. Thus when linking with libncurses.so, one
additionally needs to link with libtinfo.so. Ncurses provides a config script
(ncurses5-config) to assist finding ncurses.

This patch replaces the old heuristic for detection of ncurses libs for
linking the ncurses menuconfig dialog by the use of the config scripts.
This results in the requirement of ncurses version 5.6 or newer for menuconfig.

Signed-off-by: Justin Lecher <jlec@...too.org>
---
 scripts/kconfig/lxdialog/check-lxdialog.sh | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/scripts/kconfig/lxdialog/check-lxdialog.sh b/scripts/kconfig/lxdialog/check-lxdialog.sh
index c8e8a71..10df55b 100644
--- a/scripts/kconfig/lxdialog/check-lxdialog.sh
+++ b/scripts/kconfig/lxdialog/check-lxdialog.sh
@@ -4,15 +4,8 @@
 # What library to link
 ldflags()
 {
-	for ext in so a dll.a dylib ; do
-		for lib in ncursesw ncurses curses ; do
-			$cc -print-file-name=lib${lib}.${ext} | grep -q /
-			if [ $? -eq 0 ]; then
-				echo "-l${lib}"
-				exit
-			fi
-		done
-	done
+	ncursesw5-config --libs 2>/dev/null && exit
+	ncurses5-config --libs 2>/dev/null && exit
 	exit 1
 }
 
-- 
1.8.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/