lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:	Thu, 28 Feb 2013 13:19:30 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	oe Thornber <ejt@...hat.com>,
	Heinz Mauelshagen <mauelshagen@...hat.com>,
	Alasdair G Kergon <agk@...hat.com>
Cc:	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Joe Thornber <ejt@...hat.com>,
	Heinz Mauelshagen <mauelshagen@...hat.com>
Subject: linux-next: build failure after merge of the final tree
 (device-mapper tree related)

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/md/dm-cache-policy-cleaner.c: In function 'alloc_hash':
drivers/md/dm-cache-policy-cleaner.c:87:2: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration]
drivers/md/dm-cache-policy-cleaner.c:87:14: warning: assignment makes pointer from integer without a cast [enabled by default]
drivers/md/dm-cache-policy-cleaner.c: In function 'free_hash':
drivers/md/dm-cache-policy-cleaner.c:94:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
drivers/md/dm-cache-policy-cleaner.c: In function 'alloc_cache_blocks_with_hash':
drivers/md/dm-cache-policy-cleaner.c:101:13: warning: assignment makes pointer from integer without a cast [enabled by default]
cc1: some warnings being treated as errors
make[3]: *** [drivers/md/dm-cache-policy-cleaner.o] Error 1
drivers/md/dm-cache-policy-mq.c: In function 'alloc_bitset':
drivers/md/dm-cache-policy-mq.c:32:2: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration]
drivers/md/dm-cache-policy-mq.c:32:2: warning: return makes pointer from integer without a cast [enabled by default]
drivers/md/dm-cache-policy-mq.c: In function 'free_bitset':
drivers/md/dm-cache-policy-mq.c:37:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
make[3]: *** [drivers/md/dm-cache-policy-mq.o] Error 1
drivers/md/dm-cache-target.c: In function 'alloc_bitset':
drivers/md/dm-cache-target.c:46:2: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration]
drivers/md/dm-cache-target.c:46:2: warning: return makes pointer from integer without a cast [enabled by default]
drivers/md/dm-cache-target.c: In function 'free_bitset':
drivers/md/dm-cache-target.c:57:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]

Caused by commits d5d224ab22e4 ("Add a target that allows a fast device
such as an SSD to be used as a"), b5dc50616996 ("A cache policy that uses
a multiqueue ordered by recent hit") and 9c44464a0aed ("A simple cache
policy that writes back all data to the origin") from the device-mapper
tree.

I added the following fix patch for today:

From 0fe0a64ba2a600a10725318998c19e0b3820e6d7 Mon Sep 17 00:00:00 2001
From: Stephen Rothwell <sfr@...b.auug.org.au>
Date: Thu, 28 Feb 2013 13:11:49 +1100
Subject: [PATCH] md: use of vmalloc et al needs vmalloc.h

Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>
---
 drivers/md/dm-cache-policy-cleaner.c | 1 +
 drivers/md/dm-cache-policy-mq.c      | 1 +
 drivers/md/dm-cache-target.c         | 1 +
 3 files changed, 3 insertions(+)

diff --git a/drivers/md/dm-cache-policy-cleaner.c b/drivers/md/dm-cache-policy-cleaner.c
index 43c270a..f43896f 100644
--- a/drivers/md/dm-cache-policy-cleaner.c
+++ b/drivers/md/dm-cache-policy-cleaner.c
@@ -12,6 +12,7 @@
 #include <linux/hash.h>
 #include <linux/module.h>
 #include <linux/slab.h>
+#include <linux/vmalloc.h>
 
 /*----------------------------------------------------------------*/
 
diff --git a/drivers/md/dm-cache-policy-mq.c b/drivers/md/dm-cache-policy-mq.c
index 63ec258..d62d0c1 100644
--- a/drivers/md/dm-cache-policy-mq.c
+++ b/drivers/md/dm-cache-policy-mq.c
@@ -11,6 +11,7 @@
 #include <linux/module.h>
 #include <linux/mutex.h>
 #include <linux/slab.h>
+#include <linux/vmalloc.h>
 
 #define DM_MSG_PREFIX "cache-policy-mq"
 #define MQ_VERSION	"1.0.0"
diff --git a/drivers/md/dm-cache-target.c b/drivers/md/dm-cache-target.c
index 630f769..1215050 100644
--- a/drivers/md/dm-cache-target.c
+++ b/drivers/md/dm-cache-target.c
@@ -14,6 +14,7 @@
 #include <linux/mempool.h>
 #include <linux/module.h>
 #include <linux/slab.h>
+#include <linux/vmalloc.h>
 
 #define DM_MSG_PREFIX "cache"
 
-- 
1.8.1

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au

Content of type "application/pgp-signature" skipped

Powered by blists - more mailing lists