linux-kernel - Re: [PATCH] usb: host: tegra: Reset Tegra USB controller before init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1302281003340.1352-100000@iolanthe.rowland.org>
Date:	Thu, 28 Feb 2013 10:09:47 -0500 (EST)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Venu Byravarasu <vbyravarasu@...dia.com>
cc:	gregkh@...uxfoundation.org, <linux-usb@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <swarren@...dotorg.org>
Subject: Re: [PATCH] usb: host: tegra: Reset Tegra USB controller before init

On Thu, 28 Feb 2013, Venu Byravarasu wrote:

> To clear any configurations made by U-Boot on Tegra USB controller,
> reset it before init in probe.
> 
> Signed-off-by: Venu Byravarasu <vbyravarasu@...dia.com>
> ---
> When U-Boot configures a Tegra USB controller in device mode and if the EHCI
> driver of kernel tries to set it to HOST mode, message "irq 52: nobody cared"
> appears and IRQ gets disabled.
> 
> This issue was initially reported with: http://marc.info/?l=linux-tegra&m=136110175423601&w=2
> 
> To avoid such issues, due to configurations made by U-Boot driver, reset the
> Tegra USB controller, before configuring it by kernel.

Does the Tegra platform use shared interrupts?  If it does, what 
happens if the IRQ is enabled and in use by another device before 
ehci-tegra resets the USB controller?

Does the unwanted interrupt occur only when the controller is switched
to host mode?  If not, it seems to me this reset belongs in the
platform code, not in the glue layer.  If yes, the reset belongs
somewher before the controller is switched -- where does that occur?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/