linux-kernel - Re: [PATCH] staging: si3226x: TDM: add issues to TODO file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 28 Feb 2013 08:57:20 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Kurachkin Michail <Michail.Kurachkin@...mwad.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Kuten Ivan <Ivan.Kuten@...mwad.com>,
	"benavi@...vell.com" <benavi@...vell.com>,
	Viktar Palstsiuk <Viktar.Palstsiuk@...mwad.com>,
	Gorokh Dmitriy <Dmitriy.Gorokh@...mwad.com>
Subject: Re: [PATCH] staging: si3226x: TDM: add issues to TODO file

On Thu, Feb 28, 2013 at 04:30:52PM +0000, Kurachkin Michail wrote:
> Signed-off-by: Michail Kurachkin <michail.kurachkin@...mwad.com>
> ---
>  drivers/staging/si3226x/TODO |   20 +++++++++++++++++---
>  drivers/staging/tdm/TODO     |   19 +++++++++++++++++++
>  2 files changed, 36 insertions(+), 3 deletions(-)
>  create mode 100644 drivers/staging/tdm/TODO
> 
> diff --git a/drivers/staging/si3226x/TODO b/drivers/staging/si3226x/TODO
> index b2cb27e..e4c334a 100644
> --- a/drivers/staging/si3226x/TODO
> +++ b/drivers/staging/si3226x/TODO
> @@ -1,8 +1,22 @@
> +Mainteiners:
> +Michail Kurachkin <Michail.Kurachkin@...mwad.com> <stelhs@...dex.ru>
> +Ivan Kuten <ivan.kuten@...mwad.com>
> +Promwad company <info@...mwad.com>
> +
> +Reviwers:
> +Oliver Neukum <oneukum@...e.de>
> +Ryan Mallon <rmallon@...il.com>
> +Greg Kroah-Hartman <gregkh@...uxfoundation.org>

Why are you listing reviewers?  We've never done that in a TODO file
before, please don't start.

And this should be two patches, one for each driver.

In fact, ideally it would be part of your original series.  As I really
don't want to hand-edit the Subject: of those patches, can you just fix
this up properly and resend all of them, based on the comments I've
provided so far?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/