linux-kernel - Re: [tpmdd-devel] [PATCH RESEND] char/tpm: Convert struct i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130228233235.5f279117@endymion.delvare>
Date:	Thu, 28 Feb 2013 23:32:35 +0100
From:	Jean Delvare <khali@...ux-fr.org>
To:	Peter Hüwe <PeterHuewe@....de>
Cc:	tpmdd-devel@...ts.sourceforge.net,
	Kent Yoder <key@...ux.vnet.ibm.com>, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [tpmdd-devel] [PATCH RESEND] char/tpm: Convert struct i2c_msg
 initialization to C99 format

On Thu, 28 Feb 2013 23:12:51 +0100, Peter Hüwe wrote:
> thanks for resending.

You're welcome.

> Am Donnerstag, 28. Februar 2013, 11:06:11 schrieb Jean Delvare:
> > From: Shubhrajyoti Datta <omaplinuxkernel@...il.com>
> > 
> > Convert the struct i2c_msg initialization to C99 format. This makes
> > maintaining and editing the code simpler. Also helps once other fields
> > like transferred are added in future.
> > 
> > Thanks to Julia Lawall for automating the conversion.
> > 
> > Signed-off-by: Shubhrajyoti D <shubhrajyoti@...com>
> > Acked-by: Peter Huewe <peter.huewe@...ineon.com>
> > Signed-off-by: Jean Delvare <khali@...ux-fr.org>
> > ---
> > v2: removed zero initialization of flags.
> > 
> > Patch already sent by Shubhrajyoti Datta on 2012-10-10.
> > 
> >  drivers/char/tpm/tpm_i2c_infineon.c |   19 ++++++++++++++++---
> >  1 file changed, 16 insertions(+), 3 deletions(-)
> 
> As it was not yet applied I folded it into my patch
> "Add support for new Infineon I2C TPM (SLB 9645 TT 1.2 I2C)"

I'd suggest not to. Mixing actual changes with cleanups is generally
discouraged.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/