lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 28 Feb 2013 23:28:06 +0000 From: "Yu, Fenghua" <fenghua.yu@...el.com> To: "H. Peter Anvin" <hpa@...or.com>, Borislav Petkov <bp@...en8.de>, "H. Peter Anvin" <hpa@...ux.intel.com>, Linus Torvalds <torvalds@...ux-foundation.org>, Ingo Molnar <mingo@...e.hu>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Thomas Gleixner <tglx@...utronix.de>, Yinghai Lu <yinghai@...nel.org> Subject: RE: [GIT PULL] x86/microcode for v3.9-rc1 > -----Original Message----- > From: H. Peter Anvin [mailto:hpa@...or.com] > Sent: Thursday, February 28, 2013 3:23 PM > To: Borislav Petkov; H. Peter Anvin; Linus Torvalds; Yu, Fenghua; Ingo > Molnar; Linux Kernel Mailing List; Thomas Gleixner; Yinghai Lu > Subject: Re: [GIT PULL] x86/microcode for v3.9-rc1 > > On 02/28/2013 03:16 PM, Borislav Petkov wrote: > > > > Some strange build warnings I get here: > > > > arch/x86/kernel/microcode_intel_early.c: In function > `get_matching_model_microcode.isra.3.constprop.9': > > arch/x86/kernel/microcode_intel_early.c:366:1: warning: the frame > size of 1072 bytes is larger than 1024 bytes [-Wframe-larger-than=] > > arch/x86/kernel/microcode_intel_early.c: In function > `save_mc_for_early': > > arch/x86/kernel/microcode_intel_early.c:550:1: warning: the frame > size of 1040 bytes is larger than 1024 bytes [-Wframe-larger-than=] > > > > What's up? > > > > gcc is warning that the function is using lots of stack. In the > context > that it is running in this is most likely not a problem given how small > the overrun is, but it might be worthwhile to see if there is anything > which can be moved out to static storage or some other variant. > > Static storage is tricky to use in this context since it runs in flat > linear mode (without paging, and therefore without the +3 GB offset) on > 32 bits. > > -hpa The errors might be related to the arrays defined mc_saved_tmp[MAX_UCODE_COUNT]. Could you send your .config to me so that I can reproduce the issue? I don't see the issue in my build environment and in Fengguang's test environment. Thanks. -Fenghua
Powered by blists - more mailing lists