linux-kernel - Re: [GIT PULL] Load keys from signed PE binaries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130301000020.GA13796@srcf.ucam.org>
Date:	Fri, 1 Mar 2013 00:00:20 +0000
From:	Matthew Garrett <mjg59@...f.ucam.org>
To:	Jiri Kosina <jkosina@...e.cz>
Cc:	David Howells <dhowells@...hat.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	jwboyer@...hat.com, pjones@...hat.com, vgoyal@...hat.com,
	keescook@...omium.org, keyrings@...ux-nfs.org,
	linux-kernel@...r.kernel.org, Greg KH <gregkh@...uxfoundation.org>,
	Florian Weimer <fw@...eb.enyo.de>,
	Paolo Bonzini <pbonzini@...hat.com>
Subject: Re: [GIT PULL] Load keys from signed PE binaries

On Fri, Mar 01, 2013 at 12:52:51AM +0100, Jiri Kosina wrote:
> On Thu, 28 Feb 2013, Matthew Garrett wrote:
> > If you've loaded an x.509 certificate into the kernel and it's later 
> > revoked, any module signed with the key is going to be loadable until 
> > it's revoked. I don't see an especially large difference here?
> 
> i_own_your_ring0.ko can be modprobed long after blacklisting of "hello 
> world" binary hash has happened on the very particular machine in its dbx 
> (as there is no link, in a x509-chain-of-trust-sense, between the hash of 
> the PE binary and the i_own_your_ring0.ko signature key).

Ah, I see what you mean. Yes, we should probably keep track of the 
linkage between the original hash and the key in the kernel and then 
invalidate the key if a corresponding dbx update is pushed, but it still 
seems likely that any attacker pushing the key onto your system would 
push the evil module simultaneously. The "I have an evil key but no evil 
module installed" case seems less likely.

-- 
Matthew Garrett | mjg59@...f.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/