linux-kernel - Re: [PATCH v3 1/4] regulator: core: support shared enable GPIO concept

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130301071747.GG25302@opensource.wolfsonmicro.com>
Date:	Fri, 1 Mar 2013 15:17:58 +0800
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	"Kim, Milo" <Milo.Kim@...com>
Cc:	Axel Lin <axel.lin@...ics.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 1/4] regulator: core: support shared enable GPIO
 concept

On Mon, Feb 18, 2013 at 06:50:39AM +0000, Kim, Milo wrote:

> +	pin->gpio = config->ena_gpio;
> +	pin->ena_gpio_invert = config->ena_gpio_invert;
> +	list_add(&pin->list, &regulator_ena_gpio_list);

We should really validate that the invert settings are consistent but
it's not so important since this is a user error that they'd probably
notice.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)