linux-kernel - Re: [PATCH] shmem: fix build regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130301003740.GS4503@ZenIV.linux.org.uk>
Date:	Fri, 1 Mar 2013 00:37:41 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Wolfram Sang <wsa@...-dreams.de>, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org
Subject: Re: [PATCH] shmem: fix build regression

On Thu, Feb 28, 2013 at 04:31:11PM -0800, Andrew Morton wrote:

> -#ifndef CONFIG_MMU
> -	error = ramfs_nommu_expand_for_mapping(inode, size);
> -	res = ERR_PTR(error);
> -	if (error)
> +
> +	res = ERR_PTR(ramfs_nommu_expand_for_mapping(inode, size));
> +	if (IS_ERR(res))
>  		goto put_dentry;

My variant of fix leaves #ifndef in place and makes the check if (res) goto...
I'm not opposed to killing the ifndef, but I think it should be a separate
patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/