linux-kernel - Re: [PATCH 2/2] regulators: max8998.c: use dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130301075426.GM25302@opensource.wolfsonmicro.com>
Date:	Fri, 1 Mar 2013 15:54:30 +0800
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Thiago Farina <tfransosi@...il.com>
Cc:	linux-kernel@...r.kernel.org, Liam Girdwood <lgirdwood@...il.com>
Subject: Re: [PATCH 2/2] regulators: max8998.c: use dev_err() instead of
 printk()

On Sat, Feb 23, 2013 at 12:51:26AM -0300, Thiago Farina wrote:
> Fixes the following checkpatch warning:
> 
> WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ...

This doesn't apply against current mainline, and...

> @@ -666,7 +666,7 @@ static int max8998_pmic_probe(struct platform_device *pdev)
>  		/* Check if SET1 is not equal to 0 */
>  		if (!pdata->buck1_set1) {
>  			dev_err(&pdev->dev,
> -                                "MAX8998 SET1 GPIO defined as 0 !\n");
> +				"MAX8998 SET1 GPIO defined as 0 !\n");
>  			WARN_ON(!pdata->buck1_set1);
>  			ret = -EIO;
>  			goto err_out;

...this (which is one of the failing hunks) is an indentation change
which bears no relation to the changelog.

I've applied the final hunk which looks good but please be more careful
in future.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)