linux-kernel - Re: [PATCH 10/30] staging: sync: Export sync API symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACSP8Sg=sTbJ_Yv=PdxvHQ--0_rTLN6XG3+0aFKzzHxMzVxKhw@mail.gmail.com>
Date:	Fri, 1 Mar 2013 00:21:24 -0800
From:	Erik Gilling <konkers@...roid.com>
To:	John Stultz <john.stultz@...aro.org>
Cc:	Greg KH <gregkh@...uxfoundation.org>,
	lkml <linux-kernel@...r.kernel.org>,
	Maarten Lankhorst <maarten.lankhorst@...onical.com>,
	Daniel Vetter <daniel.vetter@...ll.ch>,
	Rob Clark <robclark@...il.com>,
	Sumit Semwal <sumit.semwal@...aro.org>,
	dri-devel@...ts.freedesktop.org,
	Android Kernel Team <kernel-team@...roid.com>
Subject: Re: [PATCH 10/30] staging: sync: Export sync API symbols

On Thu, Feb 28, 2013 at 7:59 PM, John Stultz <john.stultz@...aro.org> wrote:
>>> +EXPORT_SYMBOL(sync_timeline_create);
>>
>> As these are now global, should they be a bit more "specific"?  "sync_"
>> seems pretty broad.
>
>
> Given its the sync driver, its most obvious choice, but I agree its likely
> to collide with filesystem related or other sync_ named functions that don't
> have a subsystem prefix.
>
> Any suggestions?
>
> The only good alternative I can think of is that in some private
> conversations with DanielV, he referred to Android using "sync-points".
>
> Erik: Would syncpoint_ be an ok prefix? Or do you have other ideas?

syncpoint would be semantically weird when you end up with struct
syncpoint_pt.  I'm open to suggestions as long as it works with
XXXX_pt, XXXX_timeline, and XXXX_fence.  I'll ask around the office
and see if someone has a good idea.

>> Also, EXPORT_SYMBOL_GPL() perhaps?
>>
>> And who is using these exports?
>
>
> From some quick git grepping...

As John pointed out, the exynos and msm display and code uses them.  I
know nvidia is working on adding suport to their tegra tree.  My knee
jerk reaction is to make the export as permissible as possible.  That
being said, all of the ARM SoC vendors I've worked with have GPL
kernel drivers even if their user space is closed.  I'll reach out to
them and ask for their opinions.  Are there any issues with keeping
them EXPORT_SYMBOL?

Cheers,
   Erik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/