linux-kernel - Re: [patch v1 1/5] mfd: da9055 change irq state to default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1362136337.19678.3.camel@dhruva>
Date:	Fri, 1 Mar 2013 16:42:17 +0530
From:	Ashish Jangam <ashish.jangam@...tcummins.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
CC:	Samuel Ortiz <sameo@...ux.intel.com>,
	Axel Lin <axel.lin@...il.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	<linux-kernel@...r.kernel.org>,
	David Dajun Chen <dchen@...semi.com>
Subject: Re: [patch v1 1/5] mfd: da9055 change irq state to default

On Fri, 2013-01-18 at 10:49 +0530, Ashish Jangam wrote:
> This patch changes the irq state from high to the now default low
> state.
> 
> This patch is tested on smdk6410 board.
> 
> Signed-off-by: Ashish Jangam <ashish.jangam@...tcummins.com>
> ---
>  drivers/mfd/da9055-core.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mfd/da9055-core.c b/drivers/mfd/da9055-core.c
> index f56a1a9..49cb23d 100644
> --- a/drivers/mfd/da9055-core.c
> +++ b/drivers/mfd/da9055-core.c
> @@ -391,7 +391,7 @@ int da9055_device_init(struct da9055 *da9055)
>  		da9055->irq_base = pdata->irq_base;
>  
>  	ret = regmap_add_irq_chip(da9055->regmap, da9055->chip_irq,
> -				  IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
> +				  IRQF_TRIGGER_LOW | IRQF_ONESHOT,
>  				  da9055->irq_base, &da9055_regmap_irq_chip,
>  				  &da9055->irq_data);
>  	if (ret < 0)
Can you let me know if this patch looks good to get merged?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/