linux-kernel - Re: [tip:x86/cleanups] x86_64: Use __BOOT_DS instead_of __KERNEL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE9FiQWmwj2urS-jY-+Bifdzx1z3om839qOowz0QZHtxLQoVzA@mail.gmail.com>
Date:	Fri, 1 Mar 2013 09:47:40 -0800
From:	Yinghai Lu <yinghai@...nel.org>
To:	mingo@...nel.org, hpa@...or.com, lans.zhang2008@...il.com,
	linux-kernel@...r.kernel.org, tglx@...utronix.de,
	hpa@...ux.intel.com
Cc:	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:x86/cleanups] x86_64: Use __BOOT_DS instead_of __KERNEL_DS
 for safety

On Thu, Feb 28, 2013 at 9:23 PM, tip-bot for gmail <tipbot@...or.com> wrote:
> Commit-ID:  b317219b322e36e25150d7b64f4532401779959d
> Gitweb:     http://git.kernel.org/tip/b317219b322e36e25150d7b64f4532401779959d
> Author:     gmail <lans.zhang2008@...il.com>

name is messed up.

should be

Lans Zhang <lans.zhang2008@...il.com>

> AuthorDate: Fri, 1 Mar 2013 09:20:39 +0800
> Committer:  H. Peter Anvin <hpa@...ux.intel.com>
> CommitDate: Thu, 28 Feb 2013 20:19:50 -0800
>
> x86_64: Use __BOOT_DS instead_of __KERNEL_DS for safety
>
> In startup_32, the running code still uses the initial GDT
> located in setup. Thus, __BOOT_DS is preferred. Currently
> __KERNEL_DS is lucky to equal to __BOOT_DS, but this is
> not always a safe way.
>
> Signed-off-by: Lans Zhang <lans.zhang2008@...il.com>
> Link: http://lkml.kernel.org/r/51300267.6000008@gmail.com
> Signed-off-by: H. Peter Anvin <hpa@...ux.intel.com>
> ---
>  arch/x86/boot/compressed/head_64.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/boot/compressed/head_64.S b/arch/x86/boot/compressed/head_64.S
> index c1d383d..16f24e6 100644
> --- a/arch/x86/boot/compressed/head_64.S
> +++ b/arch/x86/boot/compressed/head_64.S
> @@ -52,7 +52,7 @@ ENTRY(startup_32)
>         jnz 1f
>
>         cli
> -       movl    $(__KERNEL_DS), %eax
> +       movl    $(__BOOT_DS), %eax
>         movl    %eax, %ds
>         movl    %eax, %es
>         movl    %eax, %ss
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/