linux-kernel - Re: [ 47/53] dca: check against empty dca_domains list before unregister provider

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130301191704.GB30321@kroah.com>
Date:	Fri, 1 Mar 2013 11:17:04 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Jiri Slaby <jslaby@...e.cz>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	Jiang Liu <jiang.liu@...wei.com>,
	Gaohuai Han <hangaohuai@...wei.com>,
	Maciej Sosnowski <maciej.sosnowski@...el.com>,
	Dan Williams <djbw@...com>
Subject: Re: [ 47/53] dca: check against empty dca_domains list before
 unregister provider

On Thu, Feb 28, 2013 at 11:17:25PM +0100, Jiri Slaby wrote:
> On 02/28/2013 11:04 PM, Jiri Slaby wrote:
> > On 02/27/2013 12:58 AM, Greg Kroah-Hartman wrote:
> >> 3.0-stable review patch.  If anyone has any objections, please let me know.
> >>
> >> ------------------
> >>
> >> From: Maciej Sosnowski <maciej.sosnowski@...el.com>
> >>
> >> commit c419fcfd071cf34ba00f9f65282583772d2655e7 upstream.
> >>
> >> When providers get blocked unregister_dca_providers() is called ending up
> >> with dca_providers and dca_domain lists emptied. Dca should be prevented from
> >> trying to unregister any provider if dca_domain list is found empty.
> >>
> >> Reported-by: Jiang Liu <jiang.liu@...wei.com>
> >> Tested-by: Gaohuai Han <hangaohuai@...wei.com>
> >> Signed-off-by: Maciej Sosnowski <maciej.sosnowski@...el.com>
> >> Signed-off-by: Dan Williams <djbw@...com>
> >> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> >>
> >> ---
> >>  drivers/dca/dca-core.c |    5 +++++
> >>  1 file changed, 5 insertions(+)
> >>
> >> --- a/drivers/dca/dca-core.c
> >> +++ b/drivers/dca/dca-core.c
> >> @@ -409,6 +409,11 @@ void unregister_dca_provider(struct dca_
> >>  
> >>  	spin_lock_irqsave(&dca_lock, flags);
> >>  
> >> +	if (list_empty(&dca_domains)) {
> >> +		raw_spin_unlock_irqrestore(&dca_lock, flags);
> > 
> > Hi, this is an incorrect backport. It should be spin_unlock_irqrestore
> > obviously...
> 
> Fix attached.

Thanks, now applied.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/