linux-kernel - Re: [PATCH 2/2] mempolicy: fix typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 28 Feb 2013 20:28:19 -0500
From:	KOSAKI Motohiro <kosaki.motohiro@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	Sasha Levin <sasha.levin@...cle.com>,
	Hugh Dickins <hughd@...gle.com>, Mel Gorman <mgorman@...e.de>,
	Dave Jones <davej@...hat.com>, Hillf Danton <dhillf@...il.com>
Subject: Re: [PATCH 2/2] mempolicy: fix typo

On Thu, Feb 28, 2013 at 6:54 PM, Andrew Morton
<akpm@...ux-foundation.org> wrote:
> On Thu, 28 Feb 2013 00:25:07 -0500
> kosaki.motohiro@...il.com wrote:
>
>> From: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
>>
>> Currently, n_new is wrongly initialized. start and end parameter
>> are inverted. Let's fix it.
>>
>> ...
>>
>> --- a/mm/mempolicy.c
>> +++ b/mm/mempolicy.c
>> @@ -2390,7 +2390,7 @@ static int shared_policy_replace(struct shared_policy *sp, unsigned long start,
>>
>>                               *mpol_new = *n->policy;
>>                               atomic_set(&mpol_new->refcnt, 1);
>> -                             sp_node_init(n_new, n->end, end, mpol_new);
>> +                             sp_node_init(n_new, end, n->end, mpol_new);
>>                               n->end = start;
>>                               sp_insert(sp, n_new);
>>                               n_new = NULL;
>
> huh.  What were the runtime effects of this problem?

I think passed policy don't effect correctly. No big issue because nobody
uses route except Dave Jones testcase. (remember, until very recently,
this route has kernel crash bug and nobody have been hit.)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/